From: Giovanni Campagna <gcampagna@src.gnome.org>
Date: Wed, 27 Jun 2012 17:14:27 +0000 (+0200)
Subject: WindowTracker: fix ref counting bug in get_app_for_window()
X-Git-Tag: archive/raspbian/50.5-1+rpi1~1^2~1013^2^2~6409
X-Git-Url: https://dgit.raspbian.org/%22http://www.example.com/cgi/%22/%22http:/www.example.com/cgi/%22?a=commitdiff_plain;h=a1bb0ec7389332a8a070c2edd18409a0773245c3;p=gnome-shell.git

WindowTracker: fix ref counting bug in get_app_for_window()

get_app_for_window() is (transfer full), but shell_app_system_lookup_wmclass()
is (transfer none), so we must reference the result, or crash
occur.

https://bugzilla.gnome.org/show_bug.cgi?id=678992
---

diff --git a/src/shell-window-tracker.c b/src/shell-window-tracker.c
index b97f5422a..d2cc7a82c 100644
--- a/src/shell-window-tracker.c
+++ b/src/shell-window-tracker.c
@@ -299,7 +299,7 @@ get_app_for_window (ShellWindowTracker    *tracker,
   result = shell_app_system_lookup_wmclass (app_system,
                                             meta_window_get_wm_class (window));
   if (result != NULL)
-    return result;
+    return g_object_ref (result);
 
   result = get_app_from_window_pid (tracker, window);
   if (result != NULL)